docs(archivebox): sync template standards#326
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesPlayground Config Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mberlofa
force-pushed
the
docs/archivebox-template-standards-sync
branch
from
df53586 to
5a4004d
Compare
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - add the canonical archivebox.validate helper and validate.yaml gate - centralize fail-fast validation for backup, ingress hosts, and selector label overrides - require both S3 access key and secret key when backup uses inline credentials - add helm-unittest coverage for validation failures ## Validation - make template-standards-check CHART=archivebox - helm unittest charts/archivebox - helm lint --strict charts/archivebox - make standards-check CHART=archivebox - make validate-chart CHART=archivebox TIMEOUT=1200: FULLY VALIDATED (13 layers) - make site-sync-check CHART=archivebox - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#326 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Added fail-fast chart validation for common misconfigurations, including enabling ingress without hosts, ingress hosts missing required host values, conflicting pod label overrides, and incomplete/absent backup settings. * Strengthened S3 backup credential checks: when not using an existing S3 secret, both S3 access key and secret key must be provided together (with a consolidated error message). * **Tests** * Expanded chart validation test coverage for the above failure scenarios, including incomplete S3 backup credentials. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
mberlofa
force-pushed
the
docs/archivebox-template-standards-sync
branch
from
5a4004d to
cbb2705
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#646
Issue: helmforgedev/charts#633
Summary by CodeRabbit
archiveboxchart in the playground, enabling it to be eligible for sync alongside the other available chart options.